Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(action): run lint action against pr head #1209

Merged
merged 1 commit into from
Dec 26, 2023

Conversation

pysan3
Copy link
Contributor

@pysan3 pysan3 commented Dec 4, 2023

pull_request_target runs against the target branch (neorg/main) and not the content of the PR head.

Therefore, action results in this PR succeeds even tho the actual PR content is messed up.

@vhyrro
Copy link
Member

vhyrro commented Dec 26, 2023

Nice catch! Should hopefully prevent future issues 💜

@vhyrro vhyrro merged commit f367396 into nvim-neorg:main Dec 26, 2023
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants